[Nut-upsdev] [PATCH/RFC v2 0/3] Updates to ACP smart driver

[Michal Soltys]

On 11-02-07 14:11, Michal Soltys wrote:
> This is 2nd version of the earlier patch featuring a few new features
> and fixes to the apcsmart driver, following the remarks in:
>
> http://www.mail-archive.com/nut-upsdev@lists.alioth.debian.org/msg02294.html
>
> Major changes from v1:
>
> - handle battery.charge and battery.runtime checks at main.c level
> - handle "immutable but writable" conflict gracefully at driver level
> - dstate_getflags() and status_set_uniq() added (hope this is fine)
>
> Apart from that, minor changes and adjusted help.
>
>
> Michal Soltys (3):
>    drivers/dstate: add dstate_getflags() and status_set_uniq()
>    drivers/main.c: add tests for LB condition
>    drivers/apcsmart: updates
>
>   drivers/apcsmart.c |  562 +++++++++++++++++++++++++++++++++++++++++-----------
>   drivers/apcsmart.h |   70 ++++---
>   drivers/dstate.c   |   21 ++
>   drivers/dstate.h   |    2 +
>   drivers/main.c     |   69 +++++++
>   5 files changed, 582 insertions(+), 142 deletions(-)
>


So, any +/- comments about this approach ?