[Nut-upsdev] [PATCH/RFC v2 0/3] Updates to ACP smart driver
Arjen de Korte
nut+devel at de-korte.org
Fri Feb 18 09:49:02 UTC 2011
Citeren Michal Soltys <soltys op ziu.info>:
> So, any +/- comments about this approach ?
The reason why it is taking me so long to adopt this, is the reason
that (although you separated this is three chunks) the changes to the
apcsmart driver require to change the LB processing at the same time.
I'd prefer to delay that part of the patch until we have had time to
really dig into this. As told before, I'm OK with the remainder of the
changes you made. I'd prefer it if you could keep the LB out of this
patch and let me handle this part (since this goes deep into the
internals of drivers). One thing that I found out already, is that
main.c is not the proper place to do this. This should really be
handled in the status_commit() in dstate.c to prevent toggling between
two states (this isn't pretty).
Best regards, Arjen
Please keep list traffic on the list (off-list replies will be rejected)
More information about the Nut-upsdev