[Nut-upsdev] [PATCH/RFC 1/1] APC smart driver update and new features.

[Arjen de Korte]

Citeren Michal Soltys <soltys op ziu.info>:

> the likely options are:
>
> - handle this at driver level - e.g. preserve the immutable flag if  
> already set without setting rw (if necessary, e.g. in apcsmart if  
> ignorelb is set), ignore polling, adjust the code so it works fine,  
> etc.
> - go back to minbatt/mintime
> - add e.g. ST_FLAG_USER_OVERRIDE which would be used for any (and  
> only for) override.* in ups.conf (instead of  
> ST_FLAG_USER_IMMUTABLE), while not being encumbered by "must not be  
> rw" constraint
>
> The 1st option looks good ?

After some more thoughts, the first suggestion indeed seems the best.  
We really should allow people to override values, regardless of the  
fact that these may be writable. An override should really be that,  
unlike setting a default value where the value from the UPS would take  
precedence.

The trunk version has now been changed to do just this and also adopts  
your idea of setting 'ignorelb' on a global level to ignore any  
set_status("LB") settings by drivers. It calculates this flag instead  
from battery.charge (battery.runtime) and battery.charge.low  
(battery.runtime.low) and also warns if insufficient data is available  
to do so.

Thanks for your feedback.

Best regards, Arjen
-- 
Please keep list traffic on the list (off-list replies will be rejected)