[Nut-upsdev] [PATCH/RFC 1/1] APC smart driver update and new features.

[Michal Soltys]

On 11-02-20 12:52, Arjen de Korte wrote:
> Citeren Michal Soltys <soltys at ziu.info>:
> 
>> the likely options are:
>>
>> - handle this at driver level - e.g. preserve the immutable flag if 
>> already set without setting rw (if necessary, e.g. in apcsmart if 
>> ignorelb is set), ignore polling, adjust the code so it works fine, etc.
> 
> After some more thoughts, the first suggestion indeed seems the best. We 
> really should allow people to override values, regardless of the fact 
> that these may be writable. An override should really be that, unlike 
> setting a default value where the value from the UPS would take precedence.
> 
> The trunk version has now been changed to do just this and also adopts 
> your idea of setting 'ignorelb' on a global level to ignore any 
> set_status("LB") settings by drivers. It calculates this flag instead 
> from battery.charge (battery.runtime) and battery.charge.low 
> (battery.runtime.low) and also warns if insufficient data is available 
> to do so.
> 
> Thanks for your feedback.
> 
> Best regards, Arjen

All right, I'll adjust the patches and send the new version next week.
Thanks for quick update.