[Nut-upsdev] [nut-commits] svn commit r3739 - in trunk: docs/man drivers tools/nut-scanner

[Charles Lepple]

On Oct 4, 2012, at 6:50 PM, Arnaud Quette wrote:

> +/* IPMI auth defines, simply using FreeIPMI defines */
> +#ifndef IPMI_AUTHENTICATION_TYPE_NONE
> +  #define IPMI_AUTHENTICATION_TYPE_NONE                  0x00
> +  #define IPMI_AUTHENTICATION_TYPE_MD2                   0x01
> +  #define IPMI_AUTHENTICATION_TYPE_MD5                   0x02
> +  #define IPMI_AUTHENTICATION_TYPE_STRAIGHT_PASSWORD_KEY 0x04
> +  #define IPMI_AUTHENTICATION_TYPE_OEM_PROP              0x05
> +  #define IPMI_AUTHENTICATION_TYPE_RMCPPLUS              0x06
> +#endif /* IPMI_AUTHENTICATION_TYPE_NONE */

Hmm. Shouldn't some of the FreeIPMI stuff be moved out of the nut-scanner main() function, possibly into another file? Then it would be easier to do conditional compilation in case it is not installed.

Lots of Buildbot failures when FreeIPMI is not available, e.g. http://buildbot.networkupstools.org/public/nut/builders/Ubuntu-natty-x86/builds/230

-- 
Charles Lepple
clepple at gmail