[PATCH 1/2] Re: Make a main class OfflineImap that is being called

Nicolas Sebrecht nicolas.s-dev at laposte.net
Mon Dec 6 17:53:15 GMT 2010


On Mon, Dec 06, 2010 at 01:36:54PM +0100, Sebastian Spaeth wrote:
> 
> Rather than calling a function in a module, invoke offlineimap by
> calling an OfflineImap object.
> 
> This removes code lying outside of objects; I prefer to keep code
> within an object and provides us with a nicer Object encapsulation.
> 
> It will also ease the testing of Object functionality in unittests
> when they are introduced.

Merged.

I've noticed some whitespace (not only for this patch) failures it would
be really nice to avoid. You should do 'git diff --check' before
commiting.

-- 
Nicolas Sebrecht




More information about the OfflineIMAP-project mailing list