[PATCH] Re: Move __version__ definition etc. into __init__.py

Sebastian Spaeth Sebastian at SSpaeth.de
Tue Dec 21 09:43:56 GMT 2010


On Mon, 20 Dec 2010 19:45:14 +0100, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> I think the title is lying because __version__ didn't exist.

OK, will fix 

> You don't explain _why_ this is a _good_ change. What is "usually
> defined" might not be approppriate for us.

I don't change what is defined, I just move the location where it is
defined to a bit more standard place. Would you consider that a good
move in general (so I bother to create v2?) or should I drop that patch
From my queueue?
> > +__homepage__ = "http://github.com/spaetz/offlineimap"
> Hugh?
>
Oh, that is a leftover from my very old branch (before you stepped up as
maintainer), you can see how old that patch is. Would fix in v2.

Should I resend with comments fixed or drop?

Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/offlineimap-project/attachments/20101221/82efc6b8/attachment-0001.sig>


More information about the OfflineIMAP-project mailing list