[PATCH] Re: Move __version__ definition etc. into __init__.py

Nicolas Sebrecht nicolas.s-dev at laposte.net
Tue Dec 21 17:53:28 GMT 2010

On Tue, Dec 21, 2010 at 10:43:56AM +0100, Sebastian Spaeth wrote:
> On Mon, 20 Dec 2010 19:45:14 +0100, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:

> > You don't explain _why_ this is a _good_ change. What is "usually
> > defined" might not be approppriate for us.
> I don't change what is defined, I just move the location where it is
> defined to a bit more standard place. Would you consider that a good
> move in general (so I bother to create v2?) or should I drop that patch
> From my queueue?

I'm _not_ saying that the patch is irrelevant. I'm saying that the
commit message should explain _why_. If the standard way is relevant
it's fine, but at least say how valid is the standard in this case.

If you can explain _why_ we should conform to "the usually defined" way,
it's even better.

> Should I resend with comments fixed or drop?

If you intend this patch to be merged it needs a resend.

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list