[PATCH 1/4] Re: Do away with UI plugins and simplify calling the GUI
nicolas.s-dev at laposte.net
Wed Dec 22 22:31:11 GMT 2010
On Wed, Dec 22, 2010 at 03:27:17PM +0100, Sebastian Spaeth wrote:
> This change does away with the "dynamic" detection of GUIS and also
> deletes the Curses (Blinkenlights) GUI in addition to given the GUIs
> nicer names.
> Blinkenlights was not optimal for various reasons, e.g. Exceptions
> would be hidden as the screen immediately reset itself after exit. It
> also frequently messed up the screen when offlineimap crashed.
> Make the commonly called "get|setglobalui()" a function of
> offlineimap.ui and not of the weird ui.UIBase. Save the ui instance in
> various classes throughout the code rather than calling getglobalui()
> again and again.
Another dedicated patch.
> Simplify the names of the GUIs to something that a mortal can actually
> remember, make them "TTY, Basic, Quiet, Machine" with TTY being the
Yet another patch, if not two patches (use smart names, make TTY the
> This commit is huge enough.
True. It could easily be splitted, it seems. Could you refactor the
changes into atomic patches?
$ git checkout <that commit>
$ git checkout -b refactor-commit
$ git reset HEAD~1
$ git add -p
<inlude only changesets for the next commit>
$ git commit [-s]
<come back to 'git add -p' for the next round>
More information about the OfflineIMAP-project