[PATCH 1/5] Re: Remove ui.detector class

[Sebastian Spaeth]

On Wed, 5 Jan 2011 19:10:22 +0100, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> I think we should have relevant exit codes. It is really useful to get
> uniq values to know what happened in scripts. It may not be very smart
> to give a dedicated value to this error but it would be nice to keep it
> in mind for further changes.

I agree that we should use dedicated exit values, but I don't know which
ones we should be using. Should we collect/document possible exit codes
and their meanings somewhere?

This should probably not be a reason to reject this patch, but cries for
a followup patch that goes through the code assigning and documenting
exit codes for various failures.

> > --- a/offlineimap/ui/__init__.py
> > +++ b/offlineimap/ui/__init__.py
> > @@ -1,6 +1,5 @@
> > -# UI module directory
> > -# Copyright (C) 2002 John Goerzen
> > -# <jgoerzen at complete.org>
> > +# UI module
> > +# Copyright (C) 2010 Sebastian Spaeth <Sebastian at SSpaeth.de>
> 
> This isn't fair to remove previous Copyright statements, so I can't
> merge this patch as is.

Well, the full content of the file disappeared (beyond the general GPL
blurb) and was replaced with something new, so technically John's
copyright is not in this file anymore :-).

I agree though that it is not practical to record copyright information
in each file separately, that we have DVCSes for.

I would also agree that a central AUTHORS file or whatever would make more sense.

Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/offlineimap-project/attachments/20110106/ca9ac2f7/attachment-0001.sig>