[PATCH 1/5] Re: Remove ui.detector class

[Nicolas Sebrecht]

On Thu, Jan 06, 2011 at 11:50:15AM +0100, Sebastian Spaeth wrote:

> I agree that we should use dedicated exit values, but I don't know which
> ones we should be using. Should we collect/document possible exit codes
> and their meanings somewhere?

Yes, it would be nice.

> This should probably not be a reason to reject this patch, but cries for
> a followup patch that goes through the code assigning and documenting
> exit codes for various failures.

I'm not rejecting this patch because of this minor issue but the
copyright issue.

> > > --- a/offlineimap/ui/__init__.py
> > > +++ b/offlineimap/ui/__init__.py
> > > @@ -1,6 +1,5 @@
> > > -# UI module directory
> > > -# Copyright (C) 2002 John Goerzen
> > > -# <jgoerzen at complete.org>
> > > +# UI module
> > > +# Copyright (C) 2010 Sebastian Spaeth <Sebastian at SSpaeth.de>
> > 
> > This isn't fair to remove previous Copyright statements, so I can't
> > merge this patch as is.
> 
> Well, the full content of the file disappeared (beyond the general GPL
> blurb) and was replaced with something new, so technically John's
> copyright is not in this file anymore :-).

Sorry, I have no idea what you're talking about here. The statement is
still there in the tip of master and next branches.

-- 
Nicolas Sebrecht