maildir on windows share ?
Sebastian at SSpaeth.de
Sun Jul 10 21:09:30 BST 2011
On Fri, 8 Jul 2011 23:11:46 +0200, Vladimir Marek wrote:
> Ok, I'm attaching my first try. But I know neither Python on git, so
> there might be some issues I missed ...
Thanks, for someone neither knowing git nor python, you've done a great
job at mastering both so far. :)
Even nice documentation in the patch!!! +1
> --- a/offlineimap.conf
> +++ b/offlineimap.conf
> +# maildir-windows-compatible = yes
My only comment here is that the commented out value should reflect the
default value if possible (I know we don't always have it this way for
all settings now), so I would prefer a = no here. Also, we should be
using a consistent way of saying either 0/1, False/True, on/off, or
no/yes. I am not sure what we are currently using the most.
I haven't tested the rest of the patch, but it does look nice and sane
looking at the code, and if it catches all the uses of ":" ie it works
for you, then it has my
Reviewed-by: Sebastian Spaeth <Sebastian at SSpaeth.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the OfflineIMAP-project