[PATCH] Re: New account setting "maildir-windows-compatible" - That makes OfflineIMAP to use exclamation mark (!) instead of colon for storing messages. Such files can be written to windows partitions. But you will probably loose compatibility with other programs trying to read the same Maildir.

Vladimir Marek Vladimir.Marek at Oracle.COM
Tue Jul 12 20:40:30 BST 2011


Hi,

> > From: Vladimir Marek <Vladimir.Marek at oracle.com>
> 
> Missing signed-off-by line.
> 
> > ---
> >  docs/MANUAL.rst               |   21 +++++++++++++++++++++
> >  offlineimap.conf              |   10 ++++++++++
> >  offlineimap/folder/Maildir.py |   21 ++++++++++++++++-----
> >  3 files changed, 47 insertions(+), 5 deletions(-)
> 
> The commit title is way too long. A commit message is supposed to have a
> title and a body seperated by a blank line. Nothing should be written
> after the 72-80 characters per line. I've changed the message to
> 
>     Support maildir for windows
>     
>     That makes OfflineIMAP to use exclamation mark (!) instead of colon for storing
>     messages. Such files can be written to windows partitions. But you will probably
>     loose compatibility with other programs trying to read the same Maildir.

Right, it looks much better.


> In order to get it merged, I only need your signed-off-by line.

I'll probably need some help here. I can see that "git format-patch" has
-s option. Should I re-generate the patch and sent 'signed' patch?

Or just writing this line here is enough?

Signed-off-by: Vladimir Marek <vladimir.marek at oracle.com>

Thank you
-- 
	Vlad




More information about the OfflineIMAP-project mailing list