typo with maxsize and maxage

Nicolas Sebrecht nicolas.s-dev at laposte.net
Sat Jun 25 16:18:55 BST 2011

The commit title (email title) should say:

  folder/IMAP: fix typo with maxsize and maxage

On Fri, Jun 24, 2011 at 10:23:37PM +0800, Haojun Bao wrote:
> Hi,
> I found the maxsize setting unusable with Gmail, the backtrace:

We don't say "hi" or "I found" in a commit message.

>     WARNING: ERROR in syncfolder for Gmail folder LetouWork: Traceback (most recent call last):
>       File "/usr/lib/pymodules/python2.6/offlineimap/accounts.py", line 347, in syncfolder
>         remotefolder.cachemessagelist()
>       File "/usr/lib/pymodules/python2.6/offlineimap/folder/IMAP.py", line 160, in cachemessagelist
>         searchresult = imapobj.search(None, search_condition)
>       File "/usr/lib/pymodules/python2.6/offlineimap/imaplib2.py", line 904, in search
>         return self._simple_command(name, *criteria, **kw)
>       File "/usr/lib/pymodules/python2.6/offlineimap/imaplib2.py", line 1492, in _simple_command
>         return self._command_complete(self._command(name, *args), kw)
>       File "/usr/lib/pymodules/python2.6/offlineimap/imaplib2.py", line 1272, in _command_complete
>         raise self.error('%s command error: %s %s. Data: %.100s' % (rqb.name, typ, dat, rqb.data))
>     error: SEARCH command error: BAD ['Could not parse command']. Data: OCJN5 SEARCH ( SMALLER 500000)
> See the extra space in "( SMALLER 500000)"?

Traceback worth it.

>                                             It's fixed by the following
> patch:
> commit ef32ac1a8c8966d2e2dcac8531b4cd3161952b5b
> Author: baohaojun <baohaojun at gmail.com>
> Date:   Fri Jun 24 22:10:40 2011 +0800
>     maxsize/maxage: fix typo.

These extra lines aren't expected and are cleary wrong. The commit
number won't be the same in the git history. The patch exists as a plain
text file or mbox, for now. The number will be generated while applying
it in my local repository.

At the end of the mail you're missing the --  field.

Notice that 'git format-patch' and 'git send-email' do care about most
of these issues for you. ,-)

Please, fix and resend!

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list