[PATCH] threadutil: Don't require the StringIO module

Sebastian Spaeth Sebastian at SSpaeth.de
Fri Mar 11 18:19:26 UTC 2011


The only reason we used it here was to do a
traceback.print_exc(StringIO()) to get a string of our traceback. But we
can simply use traceback.format_exc() which exists since python 2.4.

One less module (and it is in the way to python 3 compatability too)

Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>
---
This is against master branch.

 offlineimap/threadutil.py |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/offlineimap/threadutil.py b/offlineimap/threadutil.py
index 09c742e..f3451b8 100644
--- a/offlineimap/threadutil.py
+++ b/offlineimap/threadutil.py
@@ -17,7 +17,6 @@
 #    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 
 from threading import *
-from StringIO import StringIO
 from Queue import Queue, Empty
 import sys, traceback, thread, time
 from offlineimap.ui import getglobalui
@@ -173,9 +172,8 @@ class ExitNotifyThread(Thread):
             self.setExitCause('EXCEPTION')
             if sys:
                 self.setExitException(sys.exc_info()[1])
-                sbuf = StringIO()
-                traceback.print_exc(file = sbuf)
-                self.setExitStackTrace(sbuf.getvalue())
+                tb = traceback.format_exc()
+                self.setExitStackTrace(tb)
         else:
             self.setExitCause('NORMAL')
         if not hasattr(self, 'exitmessage'):
-- 
1.7.1




More information about the OfflineIMAP-project mailing list