[PATCH 1/3] Re: Remove a darwin-specific workaround for read()

Sebastian Spaeth Sebastian at SSpaeth.de
Wed Mar 23 16:02:58 GMT 2011


On Tue, 22 Mar 2011 18:46:19 +0100, Nicolas Sebrecht wrote:
> On Tue, Mar 22, 2011 at 03:51:42PM +0100, Vincent Beffara wrote:
> > 
> > Because of a buggy realloc() implementation in earlier versions of
> > Python on Mac OS X, we had to cut reads into manageable chunks by hand;
> > this is no more needed with Python 2.6, and besides it causes problems
> > with imaplib2, which we now use. Revert the special case to use the
> > system's read() instead, which is now safe.
> > 
> > Signed-off-by: Vincent Beffara <vbeffara at ens-lyon.fr>
> 
> Looks good to me; applied.
> Thanks, Vincent.

Do you mean all 3 patches or only the first one? For what its worth, all
three have my:

Reviewed-by: Sebastian Spaeth <Sebastian at SSpaeth.de>

if that helps :).
You haven't pushed them out to any branch yet though, have you? Neither
next, nor pu have them as far as I can see.

Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/offlineimap-project/attachments/20110323/95e667cf/attachment-0001.sig>


More information about the OfflineIMAP-project mailing list