[PATCH 1/3] Re: Remove a darwin-specific workaround for read()
nicolas.s-dev at laposte.net
Wed Mar 23 19:03:05 GMT 2011
On Wed, Mar 23, 2011 at 05:02:58PM +0100, Sebastian Spaeth wrote:
> On Tue, 22 Mar 2011 18:46:19 +0100, Nicolas Sebrecht wrote:
> > On Tue, Mar 22, 2011 at 03:51:42PM +0100, Vincent Beffara wrote:
> > >
> > > Because of a buggy realloc() implementation in earlier versions of
> > > Python on Mac OS X, we had to cut reads into manageable chunks by hand;
> > > this is no more needed with Python 2.6, and besides it causes problems
> > > with imaplib2, which we now use. Revert the special case to use the
> > > system's read() instead, which is now safe.
> > >
> > > Signed-off-by: Vincent Beffara <vbeffara at ens-lyon.fr>
> > Looks good to me; applied.
> > Thanks, Vincent.
> Do you mean all 3 patches or only the first one? For what its worth, all
> three have my:
> Reviewed-by: Sebastian Spaeth <Sebastian at SSpaeth.de>
> if that helps :).
> You haven't pushed them out to any branch yet though, have you? Neither
> next, nor pu have them as far as I can see.
Yes. I'm going to take more time before pushing anything, I think. This
will let more time to other contributors to give reviews, sign-off-by,
More information about the OfflineIMAP-project