[PATCH] Re: Fix repository 'readonly' configuration

Nicolas Sebrecht nicolas.s-dev at laposte.net
Thu Sep 15 18:20:59 BST 2011

On Thu, Sep 15, 2011 at 12:06:06PM +0200, Sebastian Spaeth wrote:
> The readonly feature was introduced to safeguard repositories from
> accidental modifications. Unfortunately, my patch treated the readonly
> setting as a string and not as a boolean, so if *anything* was set in
> the configuration file as 'readonly', this value evaluated to True
> Fortunately this was safe, we never treated a repository that we wanted
> read-only as read-write. We always treated them readonly if something
> was configured as "readonly=..." even if that was False.
> The fix is simply to use getconfboolean() rather than getconf() which
> checks for True/False/On/Off/yes/no/1/0 and hands back the correct boolean.

Merged. Thank you both!

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list