<DKIM> [PATCH 3/3] __syncmessagesto_flags: store keywords

[Nicolas Sebrecht]

On Sun, Nov 08, 2015 at 03:39:57PM -0300, Igor Almeida wrote:

> Right. I'm more interested in the internals right now, that is, if this
> patch will play nicely with the rest of offlineimap (and other use
> cases). For this patchset all I did was debug (and learn) my way around
> the codebase to see the minimal necessary changes for my use case
> (one-way IMAP -> maildir).

It's fine. Incremental enhancements are far from bad.

My review targets only this submitted topic so it can get merged. :-)

> > Also, I wonder how Keywords for IMAP <-> IMAP is currently discarded.
> > 
> The default getkeywordmap() raises an exception, so selfflags is not
> changed. Is that what you mean?

Yes, if the exception is handled. Actually, I didn't check if you either
process Keywords by default and then honor the configuration or if you
only process Keywords if user has the option enabled.

> > I guess that dynamically allowing any Keyword would be the next topic.
> > :-)

> Hm... in that case offlineimap itself would have to edit the config
> file, I don't think that's what you really want.

Not really, the configuration option could be change to accept *any*
keyword. Oh, this would defeat your intend to map one letter per
keyword... unless mapping is cached but that's yet another story.

-- 
Nicolas Sebrecht