[Openstack-devel] openstack-debian-images_0.1_amd64.changes REJECTED

[Ansgar Burchardt]

Hi,

I won't accept the package in the archive in its current state:

  kpartx -av ${AMI_NAME}
  [...]
  mkfs.ext2 /dev/mapper/loop0p1

Data loss is not good.

  chroot ${MOUNT_DIR} sh -c "echo root:password | chpasswd"

Default root passwords are not good. There's no reason to do this.

  deb http://http.debian.net/debian wheezy main
  [...]
  deb http://security.debian.org/ squeeze/updates main

Maybe not.

And some minor things:

  mount -o loop /dev/mapper/loop0p1 ${MOUNT_DIR}

Why? That looks wrong.

Why is build-openstack-debian-image in /usr/bin if regular users cannot use it?

I'm also not sure if a package targeted at jessie should only be able to
install wheezy.

Ansgar

===

Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.