[parted-devel] s390 regression on 1.8.1

[Otavio Salvador]

David Cantrell <dcantrell at redhat.com> writes:

> Otavio Salvador wrote:
>> Hello folks,
>>
>> Today I managed to get a test of Parted on s390 (using hercules) and
>> it fails to reconize the disk label.
>>
>> I checked previous version of code that was being in use on Debian for
>> 1.7.1 and that works fine against our current version on 1.8.1 and
>> most of code is similar.
>>
>> Looks like the volume detection code is a bit different between both
>> of them. Since I'm not a s390 expert neither used to this part of
>> code, I ask for _HELP_.
>>
>> The patch that works on 1.7.1 is available on our previous SVN
>> repository and can be view at
>> http://svn.debian.org/wsvn/parted/debian/trunk/parted/sid/debian/patches/s390.dpatch?op=blame&rev=0&sc=0
>> probably the related code is on line 1146 but I'm not sure.
>>
>> Can someone do a look on it?
>
> I'm confused.  Are you adding the s390.patch to parted-1.8.1?  As of
> 1.8.0, DASD support has been in parted.  It works on S/390 and zSeries
> (S/390x) systems, so this could be a problem with hercules disk
> images. I can't look at it now, but I can on Thursday, probably.  I
> want to compare it on zSeries and then on hercules.

The debug information is bellow:

GNU Parted 1.8.1
Using /dev/dasdb
Welcome to GNU Parted! Type 'help' to view a list of commands.
(parted) p
../../../libparted/labels/fdasd.c:233:fdasd_initialize_anchor
../../../libparted/labels/fdasd.c:57:setpos
../../../libparted/labels/fdasd.c:57:setpos
../../../libparted/labels/fdasd.c:57:setpos
../../../libparted/labels/fdasd.c:883:fdasd_get_geometry
../../../libparted/labels/fdasd.c:862:fdasd_check_api_version
../../../libparted/labels/fdasd.c:135:fdasd_error
../../../libparted/labels/fdasd.c:827:fdasd_check_volume
../../../libparted/labels/vtoc.c:275:vtoc_read_volume_label
../../../libparted/labels/vtoc.c:157:vtoc_error
../../../libparted/labels/vtoc.c:189:vtoc_ebcdic_enc
../../../libparted/labels/vtoc.c:189:vtoc_ebcdic_enc
../../../libparted/labels/fdasd.c:100:fdasd_cleanup
Error: Unable to open /dev/dasdb - unrecognised disk label.

For Debian, right now, I readded our previous working code. After we
solve it I can remove it and use the upstream code. ;-)

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."