[parted-devel] mklabel & mkfs warning

[Otavio Salvador]

"Debarshi 'Rishi' Ray" <debarshi.ray at gmail.com> writes:

>> Not extremely important, but the functions could be written simpler as just
>> one return statement:
>
> Yes, very true. The reason I did not do so was that I modelled them on
> the existing _partition_warn_busy and _disk_warn_busy functions. In
> those functions also, the inner 'if' branch can be simplified by a
> single return statement.
>
> If this method, the one suggested by Håkon is preferable then I am
> willing to make similar changes throughout the code. What do you say?

I personally like this idea also because it make the all code
simpler. I would like to hear from David and Leslie too.

That's a change that probably won't make 1.8.x because it'll probably
change too much code but if it proves stable we can rethink it.

Others?

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."