[parted-devel] policy regarding unused functions?

Jim Meyering jim at meyering.net
Thu Feb 15 16:20:32 CET 2007


Hello,

I'm preparing a patch that makes the build warning free,
and found some unused functions in libparted/labels/fdasd.c.
Here they are:

	(fdasd_partition_type):
	(fdasd_write_vtoc_labels):
	(fdasd_change_volser):
	(fdasd_check_volser):
	(fdasd_reread_partition_table):

I can either remove the functions altogether or wrap them
in something like:

  #ifdef UNUSED_FUNCTION
  #endif /* UNUSED_FUNCTION */

Unless someone is planning to use them, I prefer to remove them
altogether, just so that people don't waste time with dead code.

Preferences?



More information about the parted-devel mailing list