[parted-devel] policy regarding unused functions?

Otavio Salvador otavio at debian.org
Thu Feb 15 16:55:13 CET 2007


Jim Meyering <jim at meyering.net> writes:

> Hello,
>
> I'm preparing a patch that makes the build warning free,
> and found some unused functions in libparted/labels/fdasd.c.
> Here they are:
>
> 	(fdasd_partition_type):
> 	(fdasd_write_vtoc_labels):
> 	(fdasd_change_volser):
> 	(fdasd_check_volser):
> 	(fdasd_reread_partition_table):

On this specific case I think that would be better to leave fdasd out
of your patch. We have a fix on Debian package that needs to be ported
(from 1.7 release) and then dasd could be cleaned up.

David, have you had time to check the edge parted on hercules?

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."



More information about the parted-devel mailing list