[parted-devel] policy regarding unused functions?

[Jim Meyering]

Otavio Salvador <otavio at debian.org> wrote:
> Jim Meyering <jim at meyering.net> writes:
>
>> Hello,
>>
>> I'm preparing a patch that makes the build warning free,
>> and found some unused functions in libparted/labels/fdasd.c.
>> Here they are:
>>
>> 	(fdasd_partition_type):
>> 	(fdasd_write_vtoc_labels):
>> 	(fdasd_change_volser):
>> 	(fdasd_check_volser):
>> 	(fdasd_reread_partition_table):
>
> On this specific case I think that would be better to leave fdasd out
> of your patch. We have a fix on Debian package that needs to be ported
> (from 1.7 release) and then dasd could be cleaned up.

I'm easy.
But you say "fdasd", then "dasd".  I presume the latter should be "fdasd".

However, are you worried about the risk of a merge conflict?
Unless it's more than a strategic fix, they shouldn't be changing dead code