[parted-devel] porting to FreeBSD

[Siavosh Benabbas]

Hi,

On 2/23/07, Otavio Salvador <otavio at debian.org> wrote:
> "Siavosh Benabbas" <sbenabas at gmail.com> writes:
>
> > I have been hacking with Viktor Vasilev's FreeBSD patches to parted
> > and made them work on parted svn and FreeBSD 6.2-RELEASE. Currently
> > parted builds and runs with the following commands and the attached
> > patch. Can you review the patch and see if it is fit for committing?
>
> That's nice. Bellow goes my comments about the patch.
>
> For merging would be good if you could start a git repository and
> commit the patchset there. So we just need to merge it.
>
How could I do this? Could you give some pointers? Thanks.
> > diff -burN parted-trunk-fresh/parted/strlist.h parted-trunk/parted/strlist.h
> > --- parted-trunk-fresh/parted/strlist.h       Fri Feb 24 05:33:45 2006
> > +++ parted-trunk/parted/strlist.h     Thu Jan 18 00:55:59 2007
> > @@ -20,7 +20,18 @@
> >  #ifndef STRLIST_H_INCLUDED
> >  #define STRLIST_H_INCLUDED
> >
> > -#include <wchar.h>
> > +
> > +#ifdef ENABLE_NLS
> > +#       define _GNU_SOURCE
> > +#       include <wchar.h>
> > +#else
> > +#       ifdef wchar_t
> > +#               undef wchar_t
> > +#       endif
> > +#       define _GNU_SOURCE
> > +#       include <string.h>
> > +#       define wchar_t char
> > +#endif
>
> The define _GNU_SOURCE looks wrong to me since we're defining it on
> configure.ac already.
>
I will look into this.
> --
>         O T A V I O    S A L V A D O R
> ---------------------------------------------
>  E-mail: otavio at debian.org      UIN: 5906116
>  GNU/Linux User: 239058     GPG ID: 49A5F855
>  Home Page: http://otavio.ossystems.com.br
> ---------------------------------------------
> "Microsoft sells you Windows ... Linux gives
>  you the whole house."
>
Regards,
Siavosh