[parted-devel] Parted on GNU Hurd based systems

[Otavio Salvador]

Debarshi 'Rishi' Ray <debarshi.ray at gmail.com> writes:

>> Linux-specific _IOR() macro.  See include/parted/fdasd.h
>
> Do I have the green signal to remove fdasd support from Hurd for the time
> being, as David suggested? I have checked that this particular problem is
> solved by doing so?

Yes. This specific patch would be better to be send to the m-l before
commiting.

>>> The problem in 1.7.1 is that in libparted/arch/gnu.c function gnu_write has
>>> PED_SECTOR_SIZE in line number 657. This should be PED_SECTOR_SIZE_DEFAULT,
>>> which is #define'd in include/parted/unit.h. There is no #define for
>>> PED_SECTOR_SIZE. This is issue persists in the Git snapshot too.
>  
>> Yeah, this should change to PED_SECTOR_SIZE_DEFAULT
>
> Done. Pushed to 'master' branch. I also fixed a small problem in the signature
> of the function gnu_write in the same file. The firest parameter is now a
> const PedDevice.

I applied it too on the stable since it's small and a bugfix.

> A new problem has cropped up. In parted/ui.c, the function init_ui uses the
> SA_SIGINFO constant to set the flags passed to sigaction. Although the entire
> block is within a '#ifdef HAVE_SIGACTION....#endif', we are not checking
> whether the SA_SIGINFO is defined in glibc or not. While building in Debian
> GNU/Hurd 4.0 I found out that although the sigaction function is mentioned in
> /usr/include/bits/sigaction.h, SA_SIGINFO is not defined in the library. This
> seems to be a known issue in the Hurd kernel, and is confirmed by #hurd.
> According to Guillem Jover (braindmg) we should check for the availability of
> SA_SIGINFO at build-time, since it is a POSIX XSI extension.
>
> What do I do? Do I do as suggested and post the patch for review before
> pushing?

Yes. Do what was suggested and post a patch for review.

Keep on mind that this both proposed changes should be done in two
specific patches to keep the backporting and understanding of changes
as easy as possible.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."