[parted-devel] [PATCH] More correct handling of the HeaderSize field in GPT labels
Jim Meyering
jim at meyering.net
Sun Jul 8 21:33:06 UTC 2007
"Matthew S. Harris" <mharris312 at gmail.com> wrote:
> I'm trying one more time to try to get my bugfixes into Parted.
> Attached is a small patch for making Parted more understanding of GPT
> labels generated by ZFS on OpenSolaris. You already have my copyright
> assignment form. If there's anything else you need me to do before
> you can apply this, please be as explicit as possible, as I am very
> unfamiliar with Git.
>
> I have at least one more small patch I'll send after this one is taken care of.
Thanks! The patch looks fine.
You can make it easier to apply such a patch by also providing
enough information to build an addition to the test suite.
For example, can you give me a sequence of commands to create a
small image for which parted-before-your-patch fails, yet with your
patch it works?
E.g.,
dev=loop-file
dd if=/dev/zero of=$dev bs=1 count=50K 2> /dev/null
./parted -s $dev mklabel gpt
# change HeaderSize and checksum
# do something with the label, e.g., ./parted -s $dev p
More information about the parted-devel
mailing list