[parted-devel] [PATCH] More correct handling of the HeaderSize field in GPT labels

[Matthew S. Harris]

On 7/8/07, Otavio Salvador <otavio at debian.org> wrote:
> I think if there're things we're not aware of we ought to abort
> instead of continue the work and _guess_ it'll work properly. Think if
> something would be need to be changed on those "new headers" to the
> system work properly and due it we might break a user system.

I agree that we shouldn't break a user system.  (The other part of my
patch, which I'll submit after this one is resolved, deals with
breakage that Parted caused on my system.)  Whether you want to abort
for strange values of HeaderSize I don't care right now; I just want
Parted to deal properly with the partitions that OpenSolaris creates,
where HeaderSize is the block size rather than 92.

> > No, I mean that Parted cannot check the CRC of an OpenSolaris
> > partition because Parted uses a constant rather than the value of
> > HeaderSize in the disk label to determine how many bytes to compute
> > the CRC over.
>
> Isn't it a bug then?

Yes, it's a bug in Parted that Parted does not use the value of
HeaderSize in the disk label to determine how many bytes to compute
the CRC over.  That's what this patch is supposed to fix.  Regardless
of whether OpenSolaris's interpretation of the spec is correct, lots
of people have created partitions using OpenSolaris and Parted should
be able to read them.


Matthew