[parted-devel] Re: indentation changes render parted/ui.c nearly unmergeable

Debarshi 'Rishi' Ray debarshi.ray at gmail.com
Fri Mar 2 15:13:12 CET 2007


> Above, I'm talking only about one small aspect of coding style:
> whether to indent with spaces or TABs.

Ok. However the file in question, parted/ui.c was problematic not only with
respect to TABs and spaces, but also whether to use 4-spaces or 8-spaces. I
made it 8-spaces since most of the code is that way. Just imagine the havoc
that would happen if we shifted to 4-spaces globally. :-)

> If we were all to agree to reformat *both* the stable branch and
> the trunk, then we'd be done, modulo any pending patches relative
> to the pre-global-format date. Modulo the little detail of deciding
> on a formatting style, and installing a hook or two to help people
> check and adhere to the standard.

I was referring only to the 'master' branch. By 2.0 we would have made a
large number of changes to the 'master' code, so it might not matter much.
To enable the distributions to contribute patches to the 'stable-1.8.x'
code, we may leave it as it is.

Happy hacking,
Debarshi
-- 
husband    v. use sparingly; conserve; save
husbandry  n. frugality; thrift; agriculture
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20070302/915afc8c/attachment.pgp


More information about the parted-devel mailing list