[parted-devel] [PATCH]: Diagnose "ext2 FS too small" rather than triggering an assertion

Otavio Salvador otavio at debian.org
Thu May 24 17:05:29 UTC 2007


Jim Meyering <jim at meyering.net> writes:

> --- a/libparted/fs/ext2/ext2_mkfs.c
> +++ b/libparted/fs/ext2/ext2_mkfs.c
> @@ -589,6 +590,7 @@ struct ext2_fs *ext2_mkfs(struct ext2_dev_handle *handle,
>            fs_too_small = 1;
>
>  	if (fs_too_small) {
> +	diagnose_fs_too_small:
>  		ped_exception_throw (
>  			PED_EXCEPTION_ERROR,
>  			PED_EXCEPTION_CANCEL,

Isn't the label wrongly indented?

> --- /dev/null
> +++ b/tests/t3000-constraints.sh
> @@ -0,0 +1,61 @@
<...>
> +test_expect_success \
> +    'normalize the actual output' \
> +    'sed "s,
>    *
> ,,;s, $,," out > o2 && mv -f o2 out'
> +
<...>

Looks like a line break. Is it right?

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."



More information about the parted-devel mailing list