[parted-devel] [PATCH]: Diagnose "ext2 FS too small" rather than triggering an assertion

[Jim Meyering]

Otavio Salvador <otavio at debian.org> wrote:
> Jim Meyering <jim at meyering.net> writes:
>
>> --- a/libparted/fs/ext2/ext2_mkfs.c
>> +++ b/libparted/fs/ext2/ext2_mkfs.c
>> @@ -589,6 +590,7 @@ struct ext2_fs *ext2_mkfs(struct ext2_dev_handle *handle,
>>            fs_too_small = 1;
>>
>>  	if (fs_too_small) {
>> +	diagnose_fs_too_small:
>>  		ped_exception_throw (
>>  			PED_EXCEPTION_ERROR,
>>  			PED_EXCEPTION_CANCEL,
>
> Isn't the label wrongly indented?

That's how emacs indents it for me.

To be honest, I don't really care much at all
about indentation here, when there are still big blocks
of code with *no* or inconsistent indentation.

>> --- /dev/null
>> +++ b/tests/t3000-constraints.sh
>> @@ -0,0 +1,61 @@
> <...>
>> +test_expect_success \
>> +    'normalize the actual output' \
>> +    'sed "s,
>>    *
>> ,,;s, $,," out > o2 && mv -f o2 out'
>> +
> <...>
>
> Looks like a line break. Is it right?

There are ^M bytes in there, so it might look strange,
but there's no problem with the patch.