[parted-devel] [PATCH] Don't fail if unable to reread partition table

[Soren Hansen]

On Wed, Aug 06, 2008 at 12:47:55PM +0100, Colin Watson wrote:
>> I used to use parted 1.7.7 as this was what was shipped by Ubuntu and
>> Debian up until very recently. I used parted to add a partition table
>> to disk images that I'd be using for virtual machines.  When parted
>> was updated to 1.8.8, this stopped working, since parted fails if
>> telling the kernel to reread the partition table for the device in
>> question fails. However, for disk images this makes little sense.
> Hmm. Isn't the real bug here that it's trying to reread the partition
> table on a disk image? How come disk->dev->type isn't PED_DEVICE_FILE
> here?

Oh, err... I didn't realise parted was even aware of the difference. In
fact, this very bug suggested that it wasa mere luck that it ever worked
:).

Well, in that case checking for PED_DEVICE_FILE would certainly be right
approach.  I'll adjust the patch accordingly.  Thanks!

-- 
Soren Hansen               | 
Virtualisation specialist  | Ubuntu Server Team
Canonical Ltd.             | http://www.ubuntu.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/parted-devel/attachments/20080806/1eb7f5e1/attachment.pgp