[parted-devel] please support m68k atari partitioning

[Jim Meyering]

Stephen R Marenka wrote:

> Please support m68k atari partitioning. I'm sure this isn't high
> on anyone's list, but it would be nice if we could get it into
> upstream before it bitrots beyond my poor abilities of repair.
>
> The patch seems quite well tested at this point and it's pretty
> isolated from everything else, so it should be low risk. You can
> pull from the atari branch of my git repo at [1].
>
> The patch was originally written by "K.G." <k_guillaume at libertysurf.fr>
> almost 4 years ago. It's history is in the bug report at [2].
>
> I can also provide a straight patch if that is desired.

Thanks for posting.

A git patch series would be great, either via a repository
or simply "git format-patch" output.

Are the changes mentioned above already relative to parted's "next" branch?
If you're still interested in pursuing this, please rebase to next
and ensure that "make distcheck" still passes.
That runs all tests with a few different simulated sector sizes.
Also, please attribute carefully (in commit logs) any changes that you
have not written yourself.  We'll need to arrange to get a copyright
assignment from anyone who has contributed more than a few lines.
See this link
  http://git.sv.gnu.org/cgit/coreutils.git/plain/HACKING
for details on filling out copyright assignment forms.

Also, in order to expedite acceptance, it would be good to include a
test script that creates and manipulates atari partition tables.
For a most basic example, see tests/t0250-gpt.sh.
Ideally, your tests would also add a few empty partitions,
print/check results, remove a few,
print/check results again.

Be sure not to actually create file systems in those partitions.
We're trying to avoid using parted for FS-manipulation, because
that code has bit-rotted so much as to be unmaintainable.