[parted-devel] parted-release: adjustments
Joel Granados
jgranado at redhat.com
Thu Jul 23 10:36:20 UTC 2009
This is great!.
I'll push with one minor change. I'll erase the user variable, since
its no longer used.
On Thu, Jul 23, 2009 at 10:56:33AM +0200, Jim Meyering wrote:
> Joel,
>
> Here's a new version of your script.
> Changes I've made:
>
> Do not clone gnulib separately. That is no longer needed,
> and doing so is wasteful.
>
> Remove the recursive chown.
> It is not needed if you first run "make check" as non-root.
> In addition, it would cause the no-submodule-changes check to fail.
>
> ----------------------------------
> BTW, there was also a problem with maint.mk's use of xz,
> and I've fixed that via a patch to gnulib. Then I've pushed
> the parted change to make it pull the latest from gnulib,
> which includes that fix.
>
> #!/bin/bash
>
> v=""
> user=$(id -u)
^^^^ going to erase this var.
> date=$(date +%F)
> logfile="release.log"
> parted_dir=""
> key_string=""
> key_id=""
> stage_dir="$(pwd)/parted_release-$$"
>
.
.
.
> echo "parted cloned..."
>
> echo "Sanity checking..."
> _do_sanity_check || _do_fail
>
> echo "Creating the release..."
> _do_release || _do_fail
>
> _do_success
--
Joel Andres Granados
Brno, Czech Republic, Red Hat.
More information about the parted-devel
mailing list