[parted-devel] [patch] Use 'p' partition separator only when necessary

[Jim Meyering]

Phillip Susi wrote:

> On 12/06/2011 04:50 PM, Jim Meyering wrote:
>> Thanks for the reminder.
>> Can you write a test to exercise that patch, now?
>>
>> IMHO, any significant bug-fix or change in parted
>> should be accompanied by a test suite addition that exercises it.
>
> How does this look?

Thanks for the new test.
Unfortunately, at least on my F-16 (3.1.0-1.fc16.x86_64) desktop,
it leads to creation of a hung and unkillable parted process
that is running this command:

    parted -s /pe/tests/gt-t6001-psep.sh.IQaO/root/dev/mapper/plinear-25167 \
      mkpart primary fat32 1m 5m

This will probably serve as impetus for me to reboot.
Current uptime is a whopping 40 days, and a newer 3.1.4 kernel awaits.

Two nits:

When I applied that using "git am FILE", it complained about the two
trailing spaces.  "make syntax-check" would have spotted those, too.

> Subject: [PATCH] Add partition separator only when required
>
...
> diff --git a/tests/t6001-psep.sh b/tests/t6001-psep.sh
> new file mode 100644
> index 0000000..45cdc3c
> --- /dev/null
> +++ b/tests/t6001-psep.sh
> @@ -0,0 +1,87 @@
> +#!/bin/sh
> +# ensure that parted names partitions on dm disks correctly
> +
> +# Copyright (C) 2008-2011 Free Software Foundation, Inc.

For a new test, the copyright year should be only the current one.

# Copyright (C) 2011 Free Software Foundation, Inc.