[parted-devel] [PATCH] linux.c: Use sys/sysmacros.h for major/minor

[Sebastian Parschauer]

On 14.08.2018 14:45, Phillip Susi wrote:
> On 8/14/2018 2:06 AM, Sebastian Parschauer wrote:
>> Not ack. Duplicate include. I told you that commit
>> ba5e0451b51c983e40afd123b6e0d3eddb55e610
>> placed the include at an improper location. If you want to move it now,
>> then the other include should be removed.
> 
> Where's the duplicate?

3 lines below of what you can see of this patch.

$ git show ba5e0451b51c983e40afd123b6e0d3eddb55e610
commit ba5e0451b51c983e40afd123b6e0d3eddb55e610
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Sat Mar 24 17:37:02 2018 +0000

    linux: Include <sys/sysmacros.h> for major() macro.

    Since glibc 2.27 this header is required.

diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
index 31b98ab274f8..7e86b511d345 100644
--- a/libparted/arch/linux.c
+++ b/libparted/arch/linux.c
@@ -41,6 +41,7 @@
 #include <sys/utsname.h>        /* for uname() */
 #include <scsi/scsi.h>
 #include <assert.h>
+#include <sys/sysmacros.h>
 #ifdef ENABLE_DEVICE_MAPPER
 #include <libdevmapper.h>
 #endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/parted-devel/attachments/20180814/6be155eb/attachment.sig>