[parted-devel] [PATCH] linux.c: Use sys/sysmacros.h for major/minor

[Brian C. Lane]

On Tue, Aug 14, 2018 at 08:06:23AM +0200, Sebastian Parschauer wrote:
> On 13.08.2018 23:35, Brian C. Lane wrote:
> > gcc is also going to deprecate this at some point, so start using
> > sys/sysmacros.h directly.
> > 
> > Resolves: rhbz#1615592
> > ---
> >  libparted/arch/linux.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
> > index 4ec3440..8eb54fa 100644
> > --- a/libparted/arch/linux.c
> > +++ b/libparted/arch/linux.c
> > @@ -36,6 +36,7 @@
> >  #include <stdbool.h>
> >  #include <dirent.h>
> >  #include <sys/ioctl.h>
> > +#include <sys/sysmacros.h>      /* for major() and minor() */
> >  #include <sys/stat.h>
> >  #include <sys/types.h>
> >  #include <sys/utsname.h>        /* for uname() */
> > 
> 
> Not ack. Duplicate include. I told you that commit
> ba5e0451b51c983e40afd123b6e0d3eddb55e610
> placed the include at an improper location. If you want to move it now,
> then the other include should be removed.

Whoops, yes, I somehow missed the previous one on the branch I'm working
on. So ignore this patch.

But also, saying 'improper location' implies some kind of technical
problem with the location to me. eg. unexpectedly inside an #if.
Alphabetical would be ideal, but I wouldn't characterize it as improper.

-- 
Brian C. Lane (PST8PDT)