[Piuparts-devel] Bug#566672:

Cleto Martin Angelina cleto.martin at gmail.com
Tue May 4 12:28:37 UTC 2010


Hi!

I'm writing a patch for this bug and after taking a look at code I
have some questions:


if not settings.no_upgrade_test:
    if not settings.args_are_package_files:
        logging.info("Can't test upgrades: -a or --apt option used.")
    elif not chroot.apt_get_knows(packages):
        logging.info("Can't test upgrade: packages not known by apt-get.")
    elif install_upgrade_test(chroot, root_info, selections, package_list,
                                  packages):
        logging.info("PASS: Installation, upgrade and purging tests.")
    else:
        logging.error("FAIL: Installation, upgrade and purging tests.")
        panic()

Member apt_get_knows is where "apt-cache show $package" is executed.
Is it necessary to check if apt knows the packages for doing
install_upgrade_test?. If apt_get_knows returns false,
install_upgrade_test can not be executed?. If it is on this way, my
patch will be oriented to add the package to apt cache. Otherwise, I
think this error may be ignored.

What do you think?

Regards,
 Cleto.





More information about the Piuparts-devel mailing list