[Piuparts-devel] Bug#566672: Bug#566672:

[Holger Levsen]

Hi Cleto,

I'm really sorry for the late reply! I'm very happy about you hacking on 
piuparts and I know how the lack of my feedback slowed that down. I'm quite 
unhappy about this, but such is life... 

On Dienstag, 4. Mai 2010, Cleto Martin Angelina wrote:
> Hi!
>
> I'm writing a patch for this bug and after taking a look at code I
> have some questions:
>
>
> if not settings.no_upgrade_test:
>     if not settings.args_are_package_files:
>         logging.info("Can't test upgrades: -a or --apt option used.")
>     elif not chroot.apt_get_knows(packages):
>         logging.info("Can't test upgrade: packages not known by apt-get.")
>     elif install_upgrade_test(chroot, root_info, selections, package_list,
>                                   packages):
>         logging.info("PASS: Installation, upgrade and purging tests.")
>     else:
>         logging.error("FAIL: Installation, upgrade and purging tests.")
>         panic()
>
> Member apt_get_knows is where "apt-cache show $package" is executed.
> Is it necessary to check if apt knows the packages for doing
> install_upgrade_test?. 

yes. 

> If apt_get_knows returns false, 
> install_upgrade_test can not be executed?. If it is on this way, my
> patch will be oriented to add the package to apt cache. Otherwise, I
> think this error may be ignored.

if the package is not known to apt, piuparts should say so, do the 
installation and removal test and skip the upgrade test (and say so).


cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20100516/c2be5eab/attachment.pgp>