[Piuparts-devel] Bug#632046: Bug#632046: Bug#632046: Bug#632046: piuparts: Use HTTP_PROXY

[Scott Schaefer]

On 07/05/2011 08:12 PM, Scott Schaefer wrote:
> On 07/05/2011 05:49 AM, Holger Levsen wrote:
>> Hi Scott,
>>
>> On Montag, 4. Juli 2011, Scott Schaefer wrote:
>>>> awesome than you already are, you could include debian/changelog 
>>>> entries
>>>> in your patches too :-)
>>> Um ... OK.  I will have to learn how to do that.  I will add to my
>>> "Learn About ..." list :-)
>> sudo apt-get install devscripts
>> man dch
>> dch
>>
>> :-)
>
> Ah ... That will get us into long discussion about host of topics 
> concerning development workflows, packaging/release workflows, patch 
> approvals, testing, policies, reposibilities, etc., etc.  For now, I 
> would like to continue to rely on you to update the changelog.
>
>>
>>>> it also seems to contain unwanted noise about force-confdef :/
>>> I didn't see that in my (limited) testing.  I will re-test (after mod
>>> described below) and look specifically for anything about confdef.  In
>>> meantime, do you recall precisely what it reports ?
>> You misunderstood me: it's in the patch you posted, not in the output 
>> of the
>> code running...
>
> Hm ......
>
> This is against svn r907 ...
>
> $ svn log|head
> ------------------------------------------------------------------------
> r907 | holger | 2011-06-27 03:17:41 -0400 (Mon, 27 Jun 2011) | 1 line
>
> piuparts-report.py: correct a typo from the patch for #523950.
> ------------------------------------------------------------------------
>
>
> And piuparts.py:
>
> $ cksum piuparts.py
> 1279739423 86368 piuparts.py
>
> Applies with fuzz, since patch is against version with 
> "dpkg_divert.patch" already applied
> $ patch -p1 < .hg/patches/apt_proxy.patch
> patching file piuparts.py
> Hunk #1 succeeded at 677 (offset -5 lines).
>
>
> Applies cleanly with "dpkg_divert.patch" popped
>
> $ hg qpop
> popping apt_proxy.patch
> $ patch -p1 < .hg/patches/apt_proxy.patch
> patching file piuparts.py
>
> I have run result with both HTTP_PROXY set and unset, with both 
> --dpkg-force-confdef and without.
>
> I will test against the piuparts.conf I have from piatti for 
> master/slave testing.
>
> Or perhaps I'll just get the revision for apt-config coded, and test 
> the revised one :-)
>
>>
>>> I already found 'apt-config' (which addresses all three of my
>>> "issues").  I have it on my list to execute it and pull any
>>> Acquire::Proxy value from there if HTTP_PROXY is not in os.environ.  So
>>> I'll send revised patch in next 3-4 days.
>> Cool!
>>
>>
>> cheers,
>>     Holger
>>
>>
>>
>> _______________________________________________
>> Piuparts-devel mailing list
>> Piuparts-devel at lists.alioth.debian.org
>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/piuparts-devel
>

Revised patch attached.  Should apply cleanly against SVN r 907.

Uses env HTTP_PROXY in preference to apt_config value, if present.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: apt_proxy.patch
Type: text/x-patch
Size: 1840 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/piuparts-devel/attachments/20110705/c011e5a8/attachment.bin>