[Piuparts-devel] some patches for piuparts (was: Re: [PATCH] use consistent variable names for package lists)

[Holger Levsen]

Hi Andreas,

On Sonntag, 6. November 2011, Andreas Beckmann wrote:
> On 2011-11-06 00:49, Holger Levsen wrote:
> > thanks for your patches! Is your git repo publically available somewhere?
> Sorry, no.

hmpf, pity.

> Also it's some historically grown git repo based on my own
> git2svn experiments (before you started moving to git) I did after
> developing a set of patches with interrelationships became impossible in
> SVN. I finally merged it with the new piuparts.git (this was easier than
> I expected) and actually it's my first real experience with git.

ok, cool.

> My patches are maintained with topgit, so there is nothing you would
> really want to merge from my repository.

why not?

> The patches I sent are created
> with 'tg mail' and should be applyable with 'git am'.
> I hope the patch descriptions are sufficient to explain them, otherwise
> tell me and I'll elaborate more.

the problem is rather, that I need to come up with some tracking method for 
them, and the best way is the BTS. So I would now need to forward your 25 
patches of the last 12h to the BTS, make up some meaningful bug title, etc. 

quite a lot of work :(

of, I would need to go through all of them now, which will not happen.

then, the last patch you send has the description "needed for other patches", 
which is simply not something I'm gonna deal with.

so at the moment all I see I can / am willing to do, is to quickly go through 
your patches, apply the really trivial ones (like were I spelled your name 
wrong) and forget about the rest(!) :-( sorry, but please either file patches 
or give me a git repo to pull from, where each patch/feature/bugfix is in a 
seperate branch. (and where you remove branches I already have merged.)

i'm sorry, but I'm neither willing nor able to manage your patches for you.

> I'm usually not including changelog entries as I expect they could lead
> to conflicts quite often. Please add them afterwards separately or with
> 'git commit --amend' or ...

If you had a public git repo, I could use your commit messages for the 
changelog. the way it is currently you also "force me" to spend my time 
writing changelog entries for your changes, which is again putting workload on 
me...

> Is it okay if I send the patches (especially the small and trivial ones)
> only to the list without creating a bug in the BTS? There are some more
> in my queue (usually larger features) that may need revisiting and some
> more discussion, these will get a bug report (unless they have one
> already).

I only looked at 2 patches so far, one was trivial (fixing your name) the 
other was not, also introducing backwards compatibility with lenny, which is 
something I dont care about at all. So, please, use the BTS.

I will now quickly go through your patches, if you dont see me commiting them 
in the next 12h, consider them lost in the noise.

sorry. really. I totally do appreciate your patches, I just cannot handle them 
like this :(


cheers,
	Holger