[Piuparts-devel] for review: preview/compute-urls

[Holger Levsen]

Hi Andreas,

On Samstag, 2. Juni 2012, Andreas Beckmann wrote:
> Andreas Beckmann (9):
>       lib/conf: add get_{packages,sources}_url() methods
>       lib/conf: get_packages_url(): add optional distro argument

both look fine to me.

>       document mirror/distro/area/arch piuparts.conf settings

I think there should be defaults:

mirror = cdn.debian.net
distro = sid
area = main
arch = $(dpkg --print-architecture)

Setting the arch on a slave only makes sense seldomly, that is, when you let 
amd64 hosts be i386 slaves. So there should+can be a reasonable default, which 
only rarely will be overwritten.

>       p.conf: add area=main and arch=amd64
>       p-m: compute the Packages file URL
>       p-s: compute the Packages file URL
>       p-r: compute the Packages and Sources file URLs
>       p.conf: drop packages-url and sources-url

look all fine to me.

>       remove documentation of packages-url, sources-url

same. piuparts.conf.sample should have sensible defaults like described above 
and should work out of the box.

That said, installing piuparts-server should probably install a working 
piuparts setup, but without doing actual piuparts tests 24/7 without manually 
enabling this in /etc/default/piuparts...

> don't apply in the current state, needs changelog updates and some minor
> fixup (and testing it again)

pretty nice work!


cheers,
	Holger