[Piuparts-devel] piuparts server packaging

[Andreas Beckmann]

On 2012-06-18 00:49, Holger Levsen wrote:
> /etc/piuparts/piuparts.conf currently belongs to master. I think that should 
> be splitted in /etc/piuparts/master.conf and /etc/piuparts/slave.conf.. or?

for a localhost setup clearly NO, as you would have to to duplicate
nearly everything ...

I don't have a clear plan, how to deploy a truly distributed system

we should support setting the PIUPARTS_CONF env var to point to a config
file that will be used, defaulting to /etc/piuparts/piuparts.conf
=> TODO (the scripts bin/* that read the config file already do this)

its probably ok to ship the config in -master in /etc and in -slave in docs:
* -master + -slave + default config = something that works out of the box
* -slave only requires manual configuration anyway (ssh key transfer,
setup a config, select sections to run)

its probably better to have the same config file everywhere in a
distributed system and then use e.g. /etc/default/piuparts-slave to
restrict SECTIONS ... needs more thought ...

>> I'd like to ship scripts*/ together with piuparts as these scripts are
>> useful for standalone piuparts runs, too.
> 
> Right. Patches welcome ;)

>> don't use $user after the loop, just use $suser
>> chown <user><COLON_not_full_stop><group>
> 
> Havent seen those?!

chown foo.bar is deprecated, use chown foo:bar

> I've also split it into piuparts-(master|slave) now and am a bit unsure about 
> the slave package writing into the masters homedir... comments?

What gets written there? the ssh key?
piuparts-slave.postinst:
  dpkg-trigger piuparts-master-please-install-the-slave-key

>> 5cf23a1f2ea:
>> I don't agree to serving docs from piatti, the should come from the
>> local instance (but there could be a link to the latest version on piatti)
> 
> isn't it that you just disagree with the commit message or did I miss 
> something?

bad wording on my side ... docs should be served from the local
instance, but there could be an additional link to the docs on piatti