[Piuparts-devel] dave's report-performance

Andreas Beckmann debian at abeckmann.de
Sat May 26 16:35:56 UTC 2012


On 2012-05-26 17:58, Dave Steele wrote:
> On Sat, May 26, 2012 at 11:54 AM, Andreas Beckmann <debian at abeckmann.de> wrote:
> ...
>> Can you rebase these two relevant commits as a separate branch based on
>> develop?
>> * replace O(n^2) search in remove_old_logs
>> * Fix inefficient search in find_links_to_logs()
>
> done

* you probably want to add a commit that reshuffles your changelog
entries (moves piupartslib/packagesdb.py above piuparts-report.py) as
I've seen in the rrdeps branch ...
* cleanup the commit messages, the conflicts are boring
* there is unneccessary whitespace change
  e.g. def write_log_list_page( )
* looks like there is a convention to start (private) member variables
with an underscore, so use self._log_name_cache
* changelog/commit message:
  s/"Writing package templates"/the member function you fixed/

Andreas



More information about the Piuparts-devel mailing list