[Piuparts-devel] Bug#652934: Bug#652934: status

[Holger Levsen]

Hi Dave,

we're making some progress, but... (see below, not next :)

On Montag, 28. Mai 2012, Dave Steele wrote:
> piuparts-server rebased to develop.

I've just cherry-picked 89926a72e5675218abfbbd6dce50dba0292c43ad and then 
stopped at 4da7f074ba4d8bba26def132831d64b31fa6c9c8 as you added a new cron 
file without deleting the old ones. Which I like in a way, as it allows me to 
keep the setup running on piatti.d.o as it is, at least for a while. But then 
I also disklike it, as it means "code" copies. Will think about it... :)

So then I went on and cherry-picked e8a6808bcb7b966452db0f4f1b49b354f2d95112 
as I really like the feature to be able to change the $htmlroot and then I 
looked at the code again and decided I dislike the last three commits on the 
branch:

 1. the name $ht_root it ugly. $doc_root maybe?
 2. the code is ugly. set $self._doc_root and use it everywhere instead of 
adding another parameter to all function calls. 
 3. while this is very nice functionality which I want to merge asap, please 
move this into another branch. It has nothing to do with piuparts-server.


cheers,
	Holger