[Piuparts-devel] Bug#652934: Bug#652934: Bug#652934: status

[Dave Steele]

On Tue, May 29, 2012 at 6:14 AM, Holger Levsen <holger at layer-acht.org> wrote:
>
> I've just cherry-picked 89926a72e5675218abfbbd6dce50dba0292c43ad and then
> stopped at 4da7f074ba4d8bba26def132831d64b31fa6c9c8 as you added a new cron
> file without deleting the old ones. Which I like in a way, as it allows me to
> keep the setup running on piatti.d.o as it is, at least for a while. But then
> I also disklike it, as it means "code" copies. Will think about it... :)
>

I changed my mind on cron files. The next commit was rebased a while
back to install the piatti cron files instead of this one (going with
a 'least change' philosophy'). The one in conf is deleted a few
commits later.

Either way, the cron file(s) installed should be piatti-friendly. The
server should not need much customization - like maybe a piuparts.conf
and apache conf (and where are those template files)?

> So then I went on and cherry-picked e8a6808bcb7b966452db0f4f1b49b354f2d95112
> as I really like the feature to be able to change the $htmlroot and then I
> looked at the code again and decided I dislike the last three commits on the
> branch:

The last two commits came after I thought I had hit my limit on
rebasing ht_root. Looks like I was wrong about that.

>
>  1. the name $ht_root it ugly. $doc_root maybe?

'ht_root'  addresses the ambiguity between URI space and the
filesystem, and is in common use, but I'm willing to change it.

>  2. the code is ugly. set $self._doc_root and use it everywhere instead of
> adding another parameter to all function calls.

Ok  (I'm all about keeping piuparts-report pretty :-)

>  3. while this is very nice functionality which I want to merge asap, please
> move this into another branch. It has nothing to do with piuparts-server.
>

The average developer installing the server package would likely
disagree. Without it, there is a good chance that the package would
break the user's apache configuration, with more than one definition
of the web root. Also, at the moment, it is tied to the apache config
in conf.

I've done rework on the branch, to remove the duplicate cron file, add
a pretty self._doc_root, and rebase away the last two commits.