[Piuparts-devel] Bug#652934: Bug#652934: Bug#652934: Bug#652934: status

[Holger Levsen]

Hi Dave,

I tried to cherry-pick c5dfc2fa5e2c73f6ee4ce8ce213711c421064190 but the 
changelog conflicts. Please make your piuparts-server branch merge cleanly 
with current develop! Fixing the changelog would be trivial for me, but I 
believe you should provide clean patches ;-P

Thanks already! :-)

On Donnerstag, 31. Mai 2012, Dave Steele wrote:
> I changed my mind on cron files. The next commit was rebased a while
> back to install the piatti cron files instead of this one (going with
> a 'least change' philosophy'). The one in conf is deleted a few
> commits later.

If you move files around, please do that in a single commit.
 
> Either way, the cron file(s) installed should be piatti-friendly. The
> server should not need much customization - like maybe a piuparts.conf
> and apache conf (and where are those template files)?

which template files exactly?

> 'ht_root'  addresses the ambiguity between URI space and the
> filesystem, and is in common use, but I'm willing to change it.

I still have no idea what "ht" should mean...?!
 
> >  2. [please] set $self._doc_root and use it everywhere instead
> > of adding another parameter to all function calls.
> Ok  (I'm all about keeping piuparts-report pretty :-)

\o/ :) great.

> >  3. while this is very nice functionality which I want to merge asap,
> > please move this into another branch. It has nothing to do with
> > piuparts-server.
> The average developer installing the server package would likely
> disagree. Without it, there is a good chance that the package would
> break the user's apache configuration, with more than one definition
> of the web root. Also, at the moment, it is tied to the apache config
> in conf.

well, you have a point. But right now I mostly care to get the packaging 
sorted out, not yet(!) a proper configuration for everyone..  Also I do think 
that / is good default...

> I've done rework on the branch, to remove the duplicate cron file, add
> a pretty self._doc_root, and rebase away the last two commits.

yay, but see above :-)


cheers,
	Holger