[Piuparts-devel] Bug#705977: Bug#705977: Bug#705977: Bug#705977: lib/db: sort packages returned by reserve() by importance

[Dave Steele]

On Mon, Jun 17, 2013 at 7:32 AM, Andreas Beckmann <anbe at debian.org> wrote:
> On 2013-06-15 23:19, Holger Levsen wrote:
>> Hi,
>>
>>On Thu, Feb 21, 2013 at 1:52 PM, Andreas Beckmann <anbe at debian.org> wrote:
>> Patches welcome. :-)
>>
>> On Samstag, 15. Juni 2013, Dave Steele wrote:
>>> Ping - branches submitted 3 months ago.
>>
>> I just quickly reviewed dave/faster-rdep-calc and found it ok. Andreas, any
>> severe concerns?
>>
> but there are some issues with this approach, especially I'd like to get
> rid of all the exceptions and index with package names ...

You reworked get_package() underneath the dwke port back in March to
deprecate the utility of exception checking for that method, and my
adaptation went in last month. There are no try's, raises, or catches
in the submitted commits. If there is other exception work you want to
do, it is orthogonal to the submission.

To clarify, you are referring to replacing the package object argument
in the rdep metric accessor methods with package name. Package objects
are part of the public interface to PackagesDB.

I read that as no severe concerns.

> but I hvae no time this week ...
>

Does that mean the submission waits?

--
"Le mieux est l'ennemi du bien" - Voltaire