[Piuparts-devel] pull feature/no-redundant-config (was: Re: pull: for-holger2)

[Holger Levsen]

Hi,

On Mittwoch, 6. März 2013, Andreas Beckmann wrote:
> postponed tg-deps ...

thanks.
 
> added some more and moved to a feature branch on top of the new for-holger:
> 
> Andreas Beckmann (9):
>       p-s: use upgrade-test-distros to select the test
>       p-s: simplify piuparts command generation
>       p-s: make test_package() a member function of Section
>       p-s: _test_package(): use self._config
>       p-s: simplify package existence checks
>       lib/conf: add get_basetgz() method
>       p-s: add basetgz-directory setting and _get_tarball() method

not sure if basetgz-directory should really default to . 

(ie now it doesnt use an existing pbuilder base.tgz anymore..)

>       p-s: use the _get_tarball() method

diff --git a/README.txt b/README.txt
index d92660f..795fe80 100644
--- a/README.txt
+++ b/README.txt
@@ -586,8 +586,10 @@ section, too, and will serve as defaults for all other 
sections
  --print-architecture.
 
 * "chroot-tgz" is the name of the file the slave should use for
- the tarball to keep the chroot for the basic install/purge
- testing. If the tarball doesn't exist, the slave creates it.
+ the tarball containing the base chroot. The default name is
+ generated automatically from the "distro" or "upgrade-test-distros"
+ setting.  Overriding the default should no longer be necceessary.
+ If the tarball doesn't exist, the slave creates it.

-> I'd remove "Overriding the default should no longer be necceessary." - in a 
while noone will remember that it was needed once.



that said, merged+pushed+running, thanks!

> Do you want to use a basetgz-directory on piatti and share the tarballs?
> I'd recommend this ...

sure! :)


cheers,
	Holger